Merged
Conversation
- Implemented encoding for EthSecp256k1 public keys in amino format. - Added functions to encode and decode EthSecp256k1 signatures. - Updated pubkey type definitions to include EthSecp256k1. - Enhanced signing clients to handle EthSecp256k1 accounts. - Created DirectEthSecp256k1HdWallet for managing EthSecp256k1 keypairs. - Added tests for DirectEthSecp256k1HdWallet and DirectEthSecp256k1Wallet functionalities.
…nd update pubkey encoding in clients
…-usages Fix/add missing ethsecp256k1 pubkey usages
…-update-from-comments
…om-comments Fix/add missing codes and update from comments
ea43e8f to
c86203f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some final touches on top of #1814.
Great stuff, merci
Closes #1814
Closes #1351
Closes #1107
Closes #1060
(Not all of them are necessarily done but we should consolidate effort and focus on Cosmos EVM I guess)